Moderator: Moderators
Some time ago there was a widely known joke (a retarded one at that) here in Brazil that started with this exact question, but it makes no sense at all in english...Bohan wrote:You know MARIO?
Actually, I'm curious, what did you do to add the labels? Did you just work them in manually, or did you have a program that added as you disassembled the code?doppelganger wrote:Oh, goddamnit. These things are coming out of the woodwork.
Yeah, I went ahead and fixed that. Then I ran a complete check on every branch and jump in the file, and could find no others. But anyway, thanks again for finding those bugs.
My methodology was simple: I ran a disassembler on the program rom, then started at the beginning (reset vector) and traced out all the code. The first version of this file I uploaded was full of gaping code and data holes.
Anyway, sometimes I would trace out more code, sometimes I would go over the code with both FCEU and my intuition to figure out what the code did, and sometimes I did both at the same time. I was able to expedite the process of figuring out the level data format by comparing notes with others who had done SMB1 hacking in the past, and I was able to actually verify that, for the most part, their own ideas were correct. Some other parts, like enemy data, I had sparse information on. For the rest of the code, however, I was for the most part completely on my own.
It became fully functional (meaning it could be assembled) sometime in February I believe. But although it was filled with comments, it was almost completely devoid of labels. So I went back and replaced all the memory locations with addresses. Some of the values which would have led to confusion I replaced with constants. This was the part I call the clean-up phase. Still, I'm only human, and even I overlooked some of them, apparently.
Anyway, that's pretty much how I did it. It's not something that anyone else with a lot of free time and a shitload of patience couldn't do.
Yeah, but even someone who know to bake cakes needs some prior ingredients such as that poder made from cereals I have no idea how it's called in english, and you don't want to make your own each time you make a cake, because this would need your own field of weater and you'll have to cultivate it just to make poder from it to eventually bake cakes.tokumaru wrote:It's like, I don't know, a person who decorates cakes, but can not bake one. If by any chance they are required to make a cake from the start, they'll not be able to. So they can't really say they know how to make cakes, although they may have finished many of them. Same thing happens with games, I guess.
Mind repeating it in Portuguese? I'm just curious.tokumaru wrote:Some time ago there was a widely known joke (a retarded one at that) here in Brazil that started with this exact question, but it makes no sense at all in english...Bohan wrote:You know MARIO?
EDIT: Just to stay on topic: I think disassemblies are great to learn from (research), but I don't see the point in recoding the game...
It's too stupid... so, I ask that any other brazilian members around forgive me for propagating something so stupid...commodorejohn wrote:Mind repeating it in Portuguese? I'm just curious.
Sure, but I think people should understand exactly what goes on with a piece of code that was copied and pasted. If they don't, there might just be a case where this code misbehaves (when compared to their expectations) and they are just buying themselves some nasty bugs, while they could have coded something specifically tailored to their needs, and have no nasty surprises.although limited code pasting can help for educational purposes
